sirtimbly/IronCalc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIX: Floating-point precision bug in FLOOR functions

Browse Source 
Fixes #571

- Add EXCEL_PRECISION constant (15 significant digits)
- Fix FLOOR(7.1, 0.1) returning 7.0 instead of 7.1
- Apply to_excel_precision to ratio before floor/ceil operations
- Affects FLOOR, FLOOR.MATH, and FLOOR.PRECISE functions
- Add test_floor with 6 test cases
This commit is contained in:
tolgakaan12
2025-11-26 13:54:57 +00:00
committed by Nicolás Hatcher Andrés
parent c4142d4bf8
commit 2a7d59e512
4 changed files with 141 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
base/src/functions/mathematical.rs
View File

@@ -1,9 +1,9 @@
use crate::cast::NumberOrArray;
use crate::constants::{LAST_COLUMN, LAST_ROW};
use crate::constants::{EXCEL_PRECISION, LAST_COLUMN, LAST_ROW};
use crate::expressions::parser::ArrayNode;
use crate::expressions::types::CellReferenceIndex;
use crate::functions::math_util::{from_roman, to_roman_with_form};
use crate::number_format::to_precision;
use crate::number_format::{to_excel_precision, to_precision};
use crate::single_number_fn;
use crate::{
calc_result::CalcResult, expressions::parser::Node, expressions::token::Error, model::Model,
@@ -984,7 +984,9 @@ impl Model {
};
}
let result = f64::floor(value / significance) * significance;
// Apply Excel precision to the ratio to handle floating-point rounding errors
let ratio = to_excel_precision(value / significance, EXCEL_PRECISION);
let result = f64::floor(ratio) * significance;
CalcResult::Number(result)
}
@@ -1121,10 +1123,14 @@ impl Model {
}
let significance = significance.abs();
if value < 0.0 && mode != 0.0 {
let result = f64::ceil(value / significance) * significance;
// Apply Excel precision to handle floating-point rounding errors
let ratio = to_excel_precision(value / significance, EXCEL_PRECISION);
let result = f64::ceil(ratio) * significance;
CalcResult::Number(result)
} else {
let result = f64::floor(value / significance) * significance;
// Apply Excel precision to handle floating-point rounding errors
let ratio = to_excel_precision(value / significance, EXCEL_PRECISION);
let result = f64::floor(ratio) * significance;
CalcResult::Number(result)
}
}
@@ -1154,7 +1160,9 @@ impl Model {
return CalcResult::Number(0.0);
}
let result = f64::floor(value / significance) * significance;
// Apply Excel precision to handle floating-point rounding errors
let ratio = to_excel_precision(value / significance, EXCEL_PRECISION);
let result = f64::floor(ratio) * significance;
CalcResult::Number(result)
}