From 3191e12b939c9c544bee916ef17e8f2fd32fa9aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Hatcher?= Date: Sun, 28 Sep 2025 10:38:57 +0200 Subject: [PATCH] FIX: Make clippy happy --- base/src/functions/logical.rs | 4 ++-- base/src/functions/statistical.rs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/base/src/functions/logical.rs b/base/src/functions/logical.rs index f655f8f..15a9128 100644 --- a/base/src/functions/logical.rs +++ b/base/src/functions/logical.rs @@ -246,7 +246,7 @@ impl Model { } // None of the cases matched so we return the default // If there is an even number of args is the last one otherwise is #N/A - if args_count % 2 == 0 { + if args_count.is_multiple_of(2) { return self.evaluate_node_in_context(&args[args_count - 1], cell); } CalcResult::Error { @@ -262,7 +262,7 @@ impl Model { if args_count < 2 { return CalcResult::new_args_number_error(cell); } - if args_count % 2 != 0 { + if !args_count.is_multiple_of(2) { // Missing value for last condition return CalcResult::new_args_number_error(cell); } diff --git a/base/src/functions/statistical.rs b/base/src/functions/statistical.rs index cdb9364..a013688 100644 --- a/base/src/functions/statistical.rs +++ b/base/src/functions/statistical.rs @@ -350,7 +350,7 @@ impl Model { // FIXME: This function shares a lot of code with apply_ifs. Can we merge them? pub(crate) fn fn_countifs(&mut self, args: &[Node], cell: CellReferenceIndex) -> CalcResult { let args_count = args.len(); - if args_count < 2 || args_count % 2 == 1 { + if args_count < 2 || !args_count.is_multiple_of(2) { return CalcResult::new_args_number_error(cell); } @@ -476,7 +476,7 @@ impl Model { F: FnMut(f64), { let args_count = args.len(); - if args_count < 3 || args_count % 2 == 0 { + if args_count < 3 || args_count.is_multiple_of(2) { return Err(CalcResult::new_args_number_error(cell)); } let arg_0 = self.evaluate_node_in_context(&args[0], cell);