From 33e9894f9b63643f8bd6a6d24e299e07b470fc3b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nicol=C3=A1s=20Hatcher?= <nicolas@theuniverse.today>
Date: Thu, 3 Jul 2025 22:47:22 +0200
Subject: [PATCH] FIX: Quote sheet names properly

This is a "Hot Fix". A proper fix should use the wasm module
---
 webapp/IronCalc/src/components/util.ts | 33 ++++++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

diff --git a/webapp/IronCalc/src/components/util.ts b/webapp/IronCalc/src/components/util.ts
index a804b3e..52b6dd7 100644
--- a/webapp/IronCalc/src/components/util.ts
+++ b/webapp/IronCalc/src/components/util.ts
@@ -3,6 +3,34 @@ import type { Area, Cell } from "./types";
 import { type SelectedView, columnNameFromNumber } from "@ironcalc/wasm";
 import { LAST_COLUMN, LAST_ROW } from "./WorksheetCanvas/constants";
 
+// FIXME: Use the `quoteName` function from the wasm module
+function nameNeedsQuoting(name: string): boolean {
+  // it contains any of these characters: ()'$,;-+{} or space
+  for (const char of name) {
+    if (" ()'$,;-+{}".includes(char)) {
+      return true;
+    }
+  }
+
+  // TODO:
+  // - cell reference in A1 notation, e.g. B1048576 is quoted, B1048577 is not
+  // - cell reference in R1C1 notation, e.g. RC, RC2, R5C, R-4C, RC-8, R, C
+  // - integers
+
+  return false;
+}
+
+/**
+ * Quotes a string sheet name if it needs to
+ * NOTE: Invalid characters in a sheet name: \, /, *, [, ], :, ?
+ */
+export function quoteName(name: string): string {
+  if (nameNeedsQuoting(name)) {
+    return `'${name.replace(/'/g, "''")}'`;
+  }
+  return name;
+}
+
 /**
  *  Returns true if the keypress should start editing
  */
@@ -66,7 +94,8 @@ export function rangeToStr(
   referenceName: string,
 ): string {
   const { sheet, rowStart, rowEnd, columnStart, columnEnd } = range;
-  const sheetName = sheet === referenceSheet ? "" : `'${referenceName}'!`;
+  const sheetName =
+    sheet === referenceSheet ? "" : `${quoteName(referenceName)}!`;
   if (rowStart === rowEnd && columnStart === columnEnd) {
     return `${sheetName}${columnNameFromNumber(columnStart)}${rowStart}`;
   }
@@ -82,7 +111,7 @@ export function getFullRangeToString(
   worksheetNames: string[],
 ): string {
   const [rowStart, columnStart, rowEnd, columnEnd] = selectedView.range;
-  const sheetName = `${worksheetNames[selectedView.sheet]}`;
+  const sheetName = quoteName(worksheetNames[selectedView.sheet]);
 
   if (rowStart === rowEnd && columnStart === columnEnd) {
     return `${sheetName}!$${columnNameFromNumber(columnStart)}$${rowStart}`;