FIX: Forbid unwrap, expect and panic in the base code

bindings/python/Cargo.toml

@@ -19,6 +19,3 @@ pyo3 = { version = "0.22.3", features = ["extension-module"] }
 [features]
 extension-module = ["pyo3/extension-module"]
 default = ["extension-module"]
-
-[tool.maturin]
-features = ["pyo3/extension-module"]

bindings/python/src/lib.rs

@@ -208,6 +208,7 @@ impl PyModel {
             .map_err(|e| WorkbookError::new_err(e.to_string()))
     }
 
+    #[allow(clippy::panic)]
     pub fn test_panic(&self) -> PyResult<()> {
         panic!("This function panics for testing panic handling");
     }
@@ -240,6 +241,7 @@ pub fn create(name: &str, locale: &str, tz: &str) -> PyResult<PyModel> {
 }
 
 #[pyfunction]
+#[allow(clippy::panic)]
 pub fn test_panic() {
     panic!("This function panics for testing panic handling");
 }

bindings/wasm/src/lib.rs

@@ -274,15 +274,18 @@ impl Model {
         row: i32,
         column: i32,
     ) -> Result<JsValue, JsError> {
-        self.model
+        let style = self
+            .model
             .get_cell_style(sheet, row, column)
-            .map_err(to_js_error)
-            .map(|x| serde_wasm_bindgen::to_value(&x).unwrap())
+            .map_err(to_js_error)?;
+
+        serde_wasm_bindgen::to_value(&style).map_err(|e| to_js_error(e.to_string()))
     }
 
     #[wasm_bindgen(js_name = "onPasteStyles")]
     pub fn on_paste_styles(&mut self, styles: JsValue) -> Result<(), JsError> {
-        let styles: &Vec<Vec<Style>> = &serde_wasm_bindgen::from_value(styles).unwrap();
+        let styles: &Vec<Vec<Style>> =
+            &serde_wasm_bindgen::from_value(styles).map_err(|e| to_js_error(e.to_string()))?;
         self.model.on_paste_styles(styles).map_err(to_js_error)
     }
 
@@ -304,7 +307,10 @@ impl Model {
         )
     }
 
+    // I don't _think_ serializing to JsValue can't fail
+    // FIXME: Remove this clippy directive
     #[wasm_bindgen(js_name = "getWorksheetsProperties")]
+    #[allow(clippy::unwrap_used)]
     pub fn get_worksheets_properties(&self) -> JsValue {
         serde_wasm_bindgen::to_value(&self.model.get_worksheets_properties()).unwrap()
     }
@@ -320,7 +326,10 @@ impl Model {
         vec![sheet as i32, row, column]
     }
 
+    // I don't _think_ serializing to JsValue can't fail
+    // FIXME: Remove this clippy directive
     #[wasm_bindgen(js_name = "getSelectedView")]
+    #[allow(clippy::unwrap_used)]
     pub fn get_selected_view(&self) -> JsValue {
         serde_wasm_bindgen::to_value(&self.model.get_selected_view()).unwrap()
     }
@@ -503,8 +512,9 @@ impl Model {
         let data = self
             .model
             .copy_to_clipboard()
-            .map_err(|e| to_js_error(e.to_string()));
-        data.map(|x| serde_wasm_bindgen::to_value(&x).unwrap())
+            .map_err(|e| to_js_error(e.to_string()))?;
+
+        serde_wasm_bindgen::to_value(&data).map_err(|e| to_js_error(e.to_string()))
     }
 
     #[wasm_bindgen(js_name = "pasteFromClipboard")]