From 70366ea60c406f156cc650f52135e6fb147847ba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nicol=C3=A1s=20Hatcher?= <nicolas@theuniverse.today>
Date: Wed, 1 Jan 2025 16:08:27 +0100
Subject: [PATCH] FIX: Remove redundant variable

---
 .../NameManagerDialog/NameManagerDialog.tsx           | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/webapp/src/components/NameManagerDialog/NameManagerDialog.tsx b/webapp/src/components/NameManagerDialog/NameManagerDialog.tsx
index d94ff82..227a445 100644
--- a/webapp/src/components/NameManagerDialog/NameManagerDialog.tsx
+++ b/webapp/src/components/NameManagerDialog/NameManagerDialog.tsx
@@ -30,7 +30,6 @@ function NameManagerDialog(properties: NameManagerDialogProperties) {
   // If editingNameIndex is -2, then we are not editing any name
   // If editingNameIndex is a positive number, then we are editing that index
   const [editingNameIndex, setEditingNameIndex] = useState(-2);
-  const [showOptions, setShowOptions] = useState(true);
   const worksheets = model.getWorksheetsProperties();
   const definedNameList = model.getDefinedNameList();
 
@@ -40,14 +39,6 @@ function NameManagerDialog(properties: NameManagerDialogProperties) {
     }
   }, [open]);
 
-  useEffect(() => {
-    if (editingNameIndex !== -2) {
-      setShowOptions(false);
-    } else {
-      setShowOptions(true);
-    }
-  }, [editingNameIndex]);
-
   const formatFormula = (): string => {
     const worksheetNames = worksheets.map((s) => s.name);
     const selectedView = model.getSelectedView();
@@ -115,7 +106,7 @@ function NameManagerDialog(properties: NameManagerDialogProperties) {
                 scope={scopeName}
                 formula={definedName.formula}
                 key={definedName.name + definedName.scope}
-                showOptions={showOptions}
+                showOptions={editingNameIndex === -2}
                 onEdit={() => setEditingNameIndex(index)}
                 onDelete={() => {
                   model.deleteDefinedName(definedName.name, definedName.scope);