From 83a44314179c128d3354af4f08c0ed640ebf914f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Hatcher=20Andr=C3=A9s?= Date: Sat, 24 Aug 2024 06:59:19 +0200 Subject: [PATCH] FIX[WebApp]: Simplify loading logic of workbook (#87) Note that previously the model would have been fetched twice --- webapp/src/App.tsx | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/webapp/src/App.tsx b/webapp/src/App.tsx index dadd4ce..bc19969 100644 --- a/webapp/src/App.tsx +++ b/webapp/src/App.tsx @@ -24,20 +24,17 @@ function App() { const model_bytes = new Uint8Array( await (await fetch(`./${modelName}`)).arrayBuffer(), ); - const _model = Model.from_bytes(model_bytes); - if (!model) setModel(_model); + setModel(Model.from_bytes(model_bytes)); } catch (e) { - const _model = new Model("en", "UTC"); - if (!model) setModel(_model); + setModel(new Model("en", "UTC")); } } else { - const _model = new Model("en", "UTC"); - if (!model) setModel(_model); + setModel(new Model("en", "UTC")); } - if (!workbookState) setWorkbookState(new WorkbookState()); + setWorkbookState(new WorkbookState()); } start(); - }, [model, workbookState]); + }, []); if (!model || !workbookState) { return Loading;