FIX: Replace inline styles with StyledMenu component for improved readability

This commit is contained in:
Daniel
2024-12-12 16:15:47 +01:00
committed by Nicolás Hatcher Andrés
parent ed24e57555
commit 8c6aaf2af0

View File

@@ -34,7 +34,7 @@ const FormatMenu = (properties: FormatMenuProps) => {
> >
{properties.children} {properties.children}
</ChildrenWrapper> </ChildrenWrapper>
<Menu <StyledMenu
open={isMenuOpen} open={isMenuOpen}
onClose={(): void => setMenuOpen(false)} onClose={(): void => setMenuOpen(false)}
anchorEl={anchorElement.current} anchorEl={anchorElement.current}
@@ -46,14 +46,6 @@ const FormatMenu = (properties: FormatMenuProps) => {
vertical: "top", vertical: "top",
horizontal: "left", horizontal: "left",
}} }}
sx={{
"& .MuiPaper-root": {
borderRadius: "8px",
padding: "4px 0px",
marginLeft: "-4px", // Starting with a small offset
},
"& .MuiList-root": { padding: "0" },
}}
> >
<MenuItemWrapper onClick={(): void => onSelect(NumberFormats.AUTO)}> <MenuItemWrapper onClick={(): void => onSelect(NumberFormats.AUTO)}>
<MenuItemText>{t("toolbar.format_menu.auto")}</MenuItemText> <MenuItemText>{t("toolbar.format_menu.auto")}</MenuItemText>
@@ -122,7 +114,7 @@ const FormatMenu = (properties: FormatMenuProps) => {
<MenuItemWrapper onClick={(): void => setPickerOpen(true)}> <MenuItemWrapper onClick={(): void => setPickerOpen(true)}>
<MenuItemText>{t("toolbar.format_menu.custom")}</MenuItemText> <MenuItemText>{t("toolbar.format_menu.custom")}</MenuItemText>
</MenuItemWrapper> </MenuItemWrapper>
</Menu> </StyledMenu>
<FormatPicker <FormatPicker
numFmt={properties.numFmt} numFmt={properties.numFmt}
onChange={onSelect} onChange={onSelect}
@@ -134,6 +126,17 @@ const FormatMenu = (properties: FormatMenuProps) => {
); );
}; };
const StyledMenu = styled(Menu)`
& .MuiPaper-root {
border-radius: 8px;
padding: 4px 0px;
margin-left: -4px; // Starting with a small offset
}
& .MuiList-root {
padding: 0;
}
`;
const MenuItemWrapper = styled(MenuItem)` const MenuItemWrapper = styled(MenuItem)`
display: flex; display: flex;
justify-content: space-between; justify-content: space-between;