From 99d42cb1e21f368862b4625c054c6e5074da40d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Hatcher?= Date: Wed, 1 Jan 2025 12:18:29 +0100 Subject: [PATCH] FIX: onDelete and onCancel are mandatory properties In general optional arguments are a bad idea, because you loose the type and all it's benefits. Did you forget an argument or you didn't need it? --- webapp/src/components/NameManagerDialog/NamedRangeActive.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/webapp/src/components/NameManagerDialog/NamedRangeActive.tsx b/webapp/src/components/NameManagerDialog/NamedRangeActive.tsx index 56ef1bd..33f8610 100644 --- a/webapp/src/components/NameManagerDialog/NamedRangeActive.tsx +++ b/webapp/src/components/NameManagerDialog/NamedRangeActive.tsx @@ -18,8 +18,8 @@ interface NamedRangeProperties { scope?: number; formula: string; onSave: () => void; - onDelete?: () => void; - onCancel?: () => void; + onDelete: () => void; + onCancel: () => void; } function NamedRangeActive(properties: NamedRangeProperties) {