From c700101f3532a94ad5b02a47c8c69b58e5d7c4db Mon Sep 17 00:00:00 2001
From: Daniel <danielglezalbo@gmail.com>
Date: Sat, 12 Jul 2025 17:55:39 +0200
Subject: [PATCH] fix: copilot suggestions

---
 .../frontend/src/components/FileMenu.tsx          | 14 ++++++++------
 .../frontend/src/components/HelpMenu.tsx          | 15 ++++++++++++---
 2 files changed, 20 insertions(+), 9 deletions(-)

diff --git a/webapp/app.ironcalc.com/frontend/src/components/FileMenu.tsx b/webapp/app.ironcalc.com/frontend/src/components/FileMenu.tsx
index c777a09..c7d1820 100644
--- a/webapp/app.ironcalc.com/frontend/src/components/FileMenu.tsx
+++ b/webapp/app.ironcalc.com/frontend/src/components/FileMenu.tsx
@@ -15,7 +15,7 @@ export function FileMenu(props: {
 }) {
   const [isMenuOpen, setMenuOpen] = useState(false);
   const [isImportMenuOpen, setImportMenuOpen] = useState(false);
-  const anchorElement = useRef<HTMLDivElement>(null);
+  const anchorElement = useRef<HTMLButtonElement>(null);
   const models = getModelsMetadata();
   const uuids = Object.keys(models);
   const selectedUuid = getSelectedUuid();
@@ -56,10 +56,12 @@ export function FileMenu(props: {
   return (
     <>
       <FileMenuWrapper
+        type="button"
         id="file-menu-button"
         onClick={(): void => setMenuOpen(true)}
         ref={anchorElement}
         $isActive={isMenuOpen}
+        aria-haspopup="true"
       >
         File
       </FileMenuWrapper>
@@ -103,13 +105,11 @@ export function FileMenu(props: {
           </StyledIcon>
           <MenuItemText>Import</MenuItemText>
         </MenuItemWrapper>
-        <MenuItemWrapper>
+        <MenuItemWrapper onClick={props.onDownload}>
           <StyledIcon>
             <FileDown />
           </StyledIcon>
-          <MenuItemText onClick={props.onDownload}>
-            Download (.xlsx)
-          </MenuItemText>
+          <MenuItemText>Download (.xlsx)</MenuItemText>
         </MenuItemWrapper>
         <MenuItemWrapper
           onClick={() => {
@@ -192,7 +192,7 @@ const MenuItemWrapper = styled(MenuItem)`
   height: 32px;
 `;
 
-const FileMenuWrapper = styled.div<{ $isActive?: boolean }>`
+const FileMenuWrapper = styled.button<{ $isActive?: boolean }>`
   display: flex;
   align-items: center;
   font-size: 12px;
@@ -201,6 +201,8 @@ const FileMenuWrapper = styled.div<{ $isActive?: boolean }>`
   border-radius: 4px;
   cursor: pointer;
   background-color: ${(props) => (props.$isActive ? "#e6e6e6" : "transparent")};
+  border: none;
+  background: none;
   &:hover {
     background-color: #f2f2f2;
   }
diff --git a/webapp/app.ironcalc.com/frontend/src/components/HelpMenu.tsx b/webapp/app.ironcalc.com/frontend/src/components/HelpMenu.tsx
index 76c332a..c239719 100644
--- a/webapp/app.ironcalc.com/frontend/src/components/HelpMenu.tsx
+++ b/webapp/app.ironcalc.com/frontend/src/components/HelpMenu.tsx
@@ -5,7 +5,7 @@ import { useRef, useState } from "react";
 
 export function HelpMenu() {
   const [isMenuOpen, setMenuOpen] = useState(false);
-  const anchorElement = useRef<HTMLDivElement>(null);
+  const anchorElement = useRef<HTMLButtonElement>(null);
 
   const handleClick = () => {
     setMenuOpen(true);
@@ -18,9 +18,11 @@ export function HelpMenu() {
   return (
     <div>
       <HelpButton
+        type="button"
         ref={anchorElement}
         id="help-button"
         aria-controls={isMenuOpen ? "help-menu" : undefined}
+        aria-haspopup="true"
         onClick={handleClick}
         $isActive={isMenuOpen}
       >
@@ -52,7 +54,11 @@ export function HelpMenu() {
         <MenuItemWrapper
           onClick={() => {
             handleClose();
-            window.open("https://docs.ironcalc.com", "_blank");
+            window.open(
+              "https://docs.ironcalc.com",
+              "_blank",
+              "noopener,noreferrer",
+            );
           }}
         >
           <StyledIcon>
@@ -66,6 +72,7 @@ export function HelpMenu() {
             window.open(
               "https://docs.ironcalc.com/features/keyboard-shortcuts.html",
               "_blank",
+              "noopener,noreferrer",
             );
           }}
         >
@@ -79,7 +86,7 @@ export function HelpMenu() {
   );
 }
 
-const HelpButton = styled.div<{ $isActive?: boolean }>`
+const HelpButton = styled.button<{ $isActive?: boolean }>`
   display: flex;
   align-items: center;
   font-size: 12px;
@@ -88,6 +95,8 @@ const HelpButton = styled.div<{ $isActive?: boolean }>`
   border-radius: 4px;
   cursor: pointer;
   background-color: ${(props) => (props.$isActive ? "#e6e6e6" : "transparent")};
+  border: none;
+  background: none;
   &:hover {
     background-color: #f2f2f2;
   }