sirtimbly/IronCalc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
294 Commits 43 Branches 6 Tags
ae661f8e938e45373a7c15468793013c4c658e8a
Commit Graph

294 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nicolás Hatcher
ae661f8e93 WIP 2024-12-30 11:46:46 +01:00
francisco aloi
e5265ce3ad refactored NameManager logic for new design 2024-12-29 18:12:00 +01:00
francisco aloi
17ba7a5f84 NamedRanges changes 2024-12-28 12:32:40 +01:00
Gian Hancock
655d663590 FIX: Make XOR, OR, AND functions more consistent with Excel 
The way these functions interpret their arguments is inconsistent with
Excel in a few ways:

- EmptyCell: Excel ignores arguments evaluating to these types of
  values, treating them as if they didn't exist.

- Text: Text cells are ignored unless they are "TRUE" or "FALSE" (case
  insensitive). EXCEPT if the string value comes from a reference, in
  which case it is always ignored regardless of its value.

- Error if no args: Excel returns a #VALUE! error for these functions if
  no arguments are provided, or if all arguments are ignored (see
  above).

- EmptyArg: Bizarrely, Unlike EmptyCell, EmptyArg is not ignored and is
  treated as if it were FALSE by Excel.

- ErrorPropagation: Excel propagates errors in the arguments and in
  cells belonging to any Range arguments.

Additionally, these functions are not consistent with each other, XOR,
OR, AND vary in how they handle the cases mentioned above.

Rectify these consistency issues by re-implementing them all in terms of
a single base function which is more consistent with Excel behavior.
 2024-12-26 15:06:54 +01:00
Gian Hancock
8ba30fde33 Add more tests for OR and XOR 
Some of these tests fail due to inconsistencies with Excel

cleanup
 2024-12-26 15:06:54 +01:00
Nicolás Hatcher
690032c811 FIX: Remove optional context in parser 
The context was optional because I thought that paring an RC formula
did not need context.

You at least need the sheet in which you are parsing
For instance toknow if a defined name is local
 2024-12-26 10:21:21 +01:00
Nicolás Hatcher
86213a8434 FIX: Add test for get_defined_name_list 
Also uses the scope instead of the opaque sheet_id
 2024-12-26 10:21:21 +01:00
Nicolás Hatcher
2ed5fb9bbc FIX: Adds some validation and tests 2024-12-26 10:21:21 +01:00
Nicolás Hatcher
e455ed14ea UPDATE: API for defined names 2024-12-26 10:21:21 +01:00
Daniel
ad2efad3ae FIX: Remove tabIndex and onKeyDown as they were not used 2024-12-25 20:04:48 +01:00
Daniel
40461b897b FIX: Adds crossRef back to UploadFileDialog 2024-12-25 20:04:48 +01:00
Daniel
2e7410552f FIX: Apply useTranslation on dialog tooltips 2024-12-25 20:04:48 +01:00
Daniel
095002710b Fix: Removed unnecessary ref 2024-12-25 20:04:48 +01:00
Daniel
8ba131011e FIX: Replace SVG "X" icons with Lucide icons for consistency in dialogs 2024-12-25 20:04:48 +01:00
Nicolás Hatcher Andrés
dbddc027fb Update test-coverage.yaml 2024-12-25 16:57:54 +01:00
Steve Fanning
de997f38f5 Minor updates to Error Types and Value Types documentation 2024-12-25 13:47:21 +01:00
Steve Fanning
df4b4ca353 Update to FV description and associated pages in the Features area. 2024-12-25 13:47:21 +01:00
Daniel
3b944cd659 FIX: Use the right icon for paste format action 2024-12-20 20:13:25 +01:00
Nicolás Hatcher Andrés
d1f2b2acdd Update test-coverage.yaml 2024-12-20 14:10:02 +01:00
Daniel González-Albo
36f915b193 Merge pull request #207 from ironcalc/feature/nicolas-hidden 
UPDATE: Hide/Unhide sheets
 2024-12-20 10:14:09 +01:00
Nicolás Hatcher
5d8e6255a3 UPDATE: Hide/Unhide sheets 2024-12-20 00:49:33 +01:00
Daniel González-Albo
73f3c06203 Merge pull request #205 from ironcalc/bugfix/nico-dialog-fixes 
FIX[WebApp]: Some fixes to the DeleteWorkbook and Import dialogs
 2024-12-20 00:16:42 +01:00
Nicolás Hatcher
13b1157c61 FIX[WebApp]: Some fixes to the DeleteWorkbook and Import dialogs 2024-12-19 21:14:05 +01:00
Daniel
44f7929f4e FIX: responsiveness 2024-12-19 17:48:54 +01:00
Daniel
23643f0fae UPDATE: connect FileMenu button to open confirmation modal 2024-12-19 17:48:54 +01:00
Daniel
ad91d47db0 UPDATE: add confirmation modal for deleting workbooks 2024-12-19 17:48:54 +01:00
Daniel
8f36a1f750 FIX: make grid header colors consistent 2024-12-19 17:37:10 +01:00
Sinan Yumurtaci
8ad407432f lint 2024-12-19 17:36:27 +01:00
Sinan Yumurtaci
ebc31780ab FIX[WebApp]: Disable delete for sheet if it is the last one 2024-12-19 17:36:27 +01:00
Daniel
6e8c47d4f6 UPDATE: Replace one preset color from color picker 2024-12-18 20:00:52 +01:00
Daniel González-Albo
ed42667e87 Merge pull request #198 from ironcalc/bugfix/nicolas-modal-fixes 
FIX[UI]: Rename modal dialog fixes
 2024-12-16 22:35:49 +01:00
Nicolás Hatcher
0cd3470a97 FIX[UI]: Rename modal dialog fixes 
This will be a standard "Prompt" widget

* ESC closes the dialog without changes
* Can copy/cut paste
 2024-12-16 21:24:41 +01:00
Daniel
ab3f9c276d FIX: Border picker cosmetics 2024-12-16 17:33:34 +01:00
Nicolás Hatcher
e098105531 FIX: When cut and paste to a different sheet origin is removed 
Fixes #193
 2024-12-16 08:01:51 +01:00
Daniel
a5919d837f UPDATE: Better active states on Sheet Nav + Double click to rename sheets 2024-12-15 21:29:10 +01:00
Daniel
f214070299 FIX: Several cosmetic changes to make the toolbar look like the figmas 2024-12-15 19:18:51 +01:00
Daniel
0b2de92053 FIX: Made menu on SheetTab consistent with Figmas 2024-12-15 19:15:34 +01:00
Nicolás Hatcher
98dc1f3b06 FIX[WebApp]: Rename navigation => SheetTabBar 
Also rename all widgets in that folder to more standard names
 2024-12-15 12:12:14 +01:00
Nicolás Hatcher
fb764fed1c FIX[WebApp]: Splits the menu.tsx in two files 
This is so that SheetListMenu and SheetRenameDialog are on its own files.

Also renamed isOpen => open and close => onClose
 2024-12-15 12:12:14 +01:00
Nicolás Hatcher
23814ec18c FIX: Several fixes on the FV function 
(1+x)^(1+y) was stringifyfied incorrectly
We still need work on this

FV now returns currency

FV(-1,-2,1) should return #DIV/0! not #NUM!
 2024-12-14 22:08:44 +01:00
Daniel
8c6aaf2af0 FIX: Replace inline styles with StyledMenu component for improved readability 2024-12-14 18:34:13 +01:00
Daniel González-Albo
ed24e57555 Merge pull request #185 from ironcalc/fix/dani-webapp-navigator 
FIX: remove legacy scrollbar styles
 2024-12-14 18:14:17 +01:00
Daniel González-Albo
e8ced73b9c Merge pull request #186 from ironcalc/fix/dani-rename-sheet-dialog 
FIX: Makes styling in Rename Sheet Dialog consistent with rest of dia…
 2024-12-14 18:13:50 +01:00
Daniel
7ba002aca4 FIX: Makes footer/navigator scrollable when there are too many sheets 2024-12-14 18:04:35 +01:00
Daniel
b0e72321b4 FIX: Makes styling in Rename Sheet Dialog consistent with rest of dialogs 2024-12-13 20:43:38 +01:00
Nicolás Hatcher
41350fbd73 FIX: Run tests again and disable GEOMEAN test 2024-12-13 16:08:46 +01:00
Gian Hancock
17cd1fee96 Validate arg count for OR function 
To be compatible with Excel, at least 1 argument is required.

Fixes #175
 2024-12-12 13:06:12 +01:00
Gian Hancock
c59148bdf6 Add tests for OR function 
Tests currently fail due to issue #175
 2024-12-12 13:06:12 +01:00
Andrew Fillmore
d4a2289826 Add GEOMEAN .xlsx, Update .md files, and Run cargo fmt 2024-12-12 05:58:20 +01:00
Andrew Fillmore
e5aff48e36 Add GEOMEAN Tests 2024-12-12 05:58:20 +01:00